Re: [PATCH] qed: Avoid implicit enum conversion in qed_iwarp_parse_rx_pkt
From: David Miller
Date: Wed Sep 26 2018 - 23:24:48 EST
From: Nathan Chancellor <natechancellor@xxxxxxxxx>
Date: Mon, 24 Sep 2018 14:42:12 -0700
> Clang warns when one enumerated type is implicitly converted to another.
>
> drivers/net/ethernet/qlogic/qed/qed_iwarp.c:1713:25: warning: implicit
> conversion from enumeration type 'enum tcp_ip_version' to different
> enumeration type 'enum qed_tcp_ip_version' [-Wenum-conversion]
> cm_info->ip_version = TCP_IPV4;
> ~ ^~~~~~~~
> drivers/net/ethernet/qlogic/qed/qed_iwarp.c:1733:25: warning: implicit
> conversion from enumeration type 'enum tcp_ip_version' to different
> enumeration type 'enum qed_tcp_ip_version' [-Wenum-conversion]
> cm_info->ip_version = TCP_IPV6;
> ~ ^~~~~~~~
> 2 warnings generated.
>
> Use the appropriate values from the expected type, qed_tcp_ip_version:
>
> TCP_IPV4 = QED_TCP_IPV4 = 0
> TCP_IPV6 = QED_TCP_IPV6 = 1
>
> Link: https://github.com/ClangBuiltLinux/linux/issues/125
> Signed-off-by: Nathan Chancellor <natechancellor@xxxxxxxxx>
Applied.