Re: [PATCH v3] memory_hotplug: Free pages as higher order

From: Arun KS
Date: Thu Sep 27 2018 - 04:09:45 EST


On 2018-09-27 12:39, Oscar Salvador wrote:
On Thu, Sep 27, 2018 at 12:28:50PM +0530, Arun KS wrote:
+ __free_pages_boot_core(page, order);

Hi,

I am not sure, but if we are going to use that function from the
memory-hotplug code,
we might want to rename that function to something more generic?
The word "boot" suggests that this is only called from the boot stage.
I ll rename it to __free_pages_core()


And what about the prefetch operations?
I saw that you removed them in your previous patch and that had some
benefits [1].

Should we remove them here as well?
Sure. Will update this as well.

Thanks,
Arun

[1] https://patchwork.kernel.org/patch/10613359/

Thanks