Re: [PATCH 06/22] linux/printk.h: use unique identifier for each struct _ddebug
From: Rasmus Villemoes
Date: Thu Sep 27 2018 - 04:41:33 EST
On 2018-09-27 10:22, Petr Mladek wrote:
> On Thu 2018-09-20 00:04:28, Rasmus Villemoes wrote:
>> Changes on x86-64 later in this series require that all struct _ddebug
>> descriptors in a translation unit uses distinct identifiers. Realize
>> that for pr_debug_ratelimited by generating such an identifier via
>> __UNIQUE_ID and pass that to an extra level of macros.
>>
>> No functional change.
>>
>> Cc: Petr Mladek <pmladek@xxxxxxxx>
>> Cc: Steven Rostedt <rostedt@xxxxxxxxxxx>
>> Signed-off-by: Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx>
>
> Acked-by: Petr Mladek <pmladek@xxxxxxxx>
>
> My understanding is that this patch would go with the other changes
> via Andrew's tree.
Yes. I'm still waiting for x86 folks to comment on the x86 parts, and if
they get rejected, this patch (and others in the series) become
pointless - unless some other 64 bit arch decides to play along.
Rasmus