Re: [PATCH 4.14 64/64] crypto: x86/aegis,morus - Do not require OSXSAVE for SSE2

From: Sudip Mukherjee
Date: Thu Sep 27 2018 - 07:30:09 EST


Hi Greg,

On Thu, Sep 27, 2018 at 10:04 AM, Greg Kroah-Hartman
<gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> 4.14-stable review patch. If anyone has any objections, please let me know.
>
> ------------------
>
> From: Ondrej Mosnacek <omosnace@xxxxxxxxxx>
>
> commit 24568b47d48ec8c906fd0f589489a08b17e1edca upstream.
>
> It turns out OSXSAVE needs to be checked only for AVX, not for SSE.
> Without this patch the affected modules refuse to load on CPUs with SSE2
> but without AVX support.
>
> Fixes: 877ccce7cbe8 ("crypto: x86/aegis,morus - Fix and simplify CPUID checks")
> Cc: <stable@xxxxxxxxxxxxxxx> # 4.18
> Reported-by: Zdenek Kaspar <zkaspar82@xxxxxxxxx>
> Signed-off-by: Ondrej Mosnacek <omosnace@xxxxxxxxxx>
> Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

I am confused with this one. I am not seeing this in the "git log"
from your 4.14.73-rc1.
I also tried to apply this from your queue to v4.14.72 and it did not
apply as it could not
find some files.

error: arch/x86/crypto/aegis128-aesni-glue.c: No such file or directory
error: arch/x86/crypto/aegis128l-aesni-glue.c: No such file or directory
error: arch/x86/crypto/aegis256-aesni-glue.c: No such file or directory
error: arch/x86/crypto/morus1280-sse2-glue.c: No such file or directory
error: arch/x86/crypto/morus640-sse2-glue.c: No such file or directory

Am I missing something?


--
Regards
Sudip