Re: [PATCH v8 11/13] nvme-pci: Add a quirk for a pseudo CMB

From: Keith Busch
Date: Thu Sep 27 2018 - 13:07:20 EST


On Thu, Sep 27, 2018 at 10:54:18AM -0600, Logan Gunthorpe wrote:
> Introduce a quirk to use CMB-like memory on older devices that have
> an exposed BAR but do not advertise support for using CMBLOC and
> CMBSIZE.
>
> We'd like to use some of these older cards to test P2P memory.
>
> Signed-off-by: Logan Gunthorpe <logang@xxxxxxxxxxxx>
> Reviewed-by: Sagi Grimberg <sagi@xxxxxxxxxxx>

The implementation looks fine, and this is why we have quirks ... but
CMB has existed since 2014! :)

Reviewed-by: Keith Busch <keith.busch@xxxxxxxxx>