Re: [QUEUED v20180920 00/16] stm class/intel_th: Queued updates for v4.20

From: Mathieu Poirier
Date: Thu Sep 27 2018 - 13:18:51 EST


On Thu, Sep 20, 2018 at 03:45:37PM +0300, Alexander Shishkin wrote:
> Hi,
>
> These are patches I have queued so far, that I'm planning to send to
> Greg for the next merge window. This is mainly support for MIPI SyS-T
> protocol and all the infrastructure changes to make it possible.
>
> MIPI SyS-T is a public standard [0] for a software-level trace protocol
> that in this instance we use on top of STM devices (if we choose to) and
> MIPI STP protocol.
>
> The old "protocol" is preserved for compatibility.

I have tested this set on my side and things work as advertised. Since I do not
have a MIPI SyS-T decoder I can't validate the output, but the mechanic behind
the functionality is simple and trivial to use. I think you have succeeded in
introducing something that could have otherwise been messy.

Tested-by: Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>

>
> [0] http://www.mipi.org/specifications/sys-t
>
> Alexander Shishkin (16):
> stm class: Rework policy node fallback
> stm class: Clarify configfs root type/operations names
> stm class: Clean up stp_configfs_init
> stm class: Introduce framing protocol drivers
> stm class: Add a helper for writing data packets
> stm class: Factor out default framing protocol
> stm class: Switch over to the protocol driver
> stm class: Add MIPI SyS-T protocol support
> stm class: p_sys-t: Add support for CLOCKSYNC packets
> stm class: p_sys-t: Document the configfs interface
> stm class: Document the MIPI SyS-T protocol usage
> intel_th: SPDX-ify the documentation
> stm class: SPDX-ify the documentation
> stm class: heartbeat: Fix whitespace
> lib: Add memcat_p(): paste 2 pointer arrays together
> stm class: Use memcat_p()
>
> .../ABI/testing/configfs-stp-policy-p_sys-t | 41 ++
> Documentation/trace/intel_th.rst | 2 +
> Documentation/trace/stm.rst | 2 +
> Documentation/trace/sys-t.rst | 62 +++
> drivers/hwtracing/stm/Kconfig | 29 ++
> drivers/hwtracing/stm/Makefile | 6 +
> drivers/hwtracing/stm/core.c | 292 +++++++++++---
> drivers/hwtracing/stm/heartbeat.c | 2 +-
> drivers/hwtracing/stm/p_basic.c | 47 +++
> drivers/hwtracing/stm/p_sys-t.c | 381 ++++++++++++++++++
> drivers/hwtracing/stm/policy.c | 148 +++++--
> drivers/hwtracing/stm/stm.h | 57 ++-
> include/linux/string.h | 7 +
> lib/Kconfig.debug | 8 +
> lib/Makefile | 1 +
> lib/string.c | 31 ++
> lib/test_memcat_p.c | 115 ++++++
> 17 files changed, 1138 insertions(+), 93 deletions(-)
> create mode 100644 Documentation/ABI/testing/configfs-stp-policy-p_sys-t
> create mode 100644 Documentation/trace/sys-t.rst
> create mode 100644 drivers/hwtracing/stm/p_basic.c
> create mode 100644 drivers/hwtracing/stm/p_sys-t.c
> create mode 100644 lib/test_memcat_p.c
>
> --
> 2.18.0
>