Re: [PATCH v4 1/3] dt-bindings: thermal: Add binding document for SR thermal

[Florian Fainelli]

On 09/27/2018 10:27 AM, Rob Herring wrote:
> On Thu, Sep 27, 2018 at 09:06:41PM +0530, Srinath Mannam wrote:
>> From: Pramod Kumar <pramod.kumar@xxxxxxxxxxxx>
>>
>> Add binding document for supported thermal implementation
>> in Stingray.
>>
>> Signed-off-by: Pramod Kumar <pramod.kumar@xxxxxxxxxxxx>
>> Signed-off-by: Srinath Mannam <srinath.mannam@xxxxxxxxxxxx>
>> Reviewed-by: Ray Jui <ray.jui@xxxxxxxxxxxx>
>> Reviewed-by: Scott Branden <scott.branden@xxxxxxxxxxxx>
>> ---
>>  .../bindings/thermal/brcm,sr-thermal.txt           | 25 ++++++++++++++++++++++
>>  1 file changed, 25 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt
>>
>> diff --git a/Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt b/Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt
>> new file mode 100644
>> index 0000000..717617b
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/thermal/brcm,sr-thermal.txt
>> @@ -0,0 +1,25 @@
>> +* Broadcom Stingray Thermal
>> +
>> +This binding describes thermal sensors that is part of Stingray SoCs.
>> +
>> +Required properties:
>> +- compatible : Must be "brcm,sr-thermal"
>> +- reg : memory where tmon data will be available.
>> +- brcm,tmon-mask: A one cell bit mask of valid TMON sources.
>> +                  Each bit represents single TMON source.
>> +- brcm,max-crit-temp: Maximum supported critical temperature.
> 
> We already have a defined binding for setting trip points. 

Indeed, and if you have multiple TMONs, they would in premise possibly
each have a different critical trip point.

> 
>> +
>> +Example:
>> +	tmons {
>> +		compatible = "simple-bus";
>> +		#address-cells = <1>;
>> +		#size-cells = <1>;
>> +		ranges = <0x0 0x0 0x8f100000 0x100>;
>> +
>> +		tmon: thermal@0 {
>> +			compatible = "brcm,sr-thermal";
>> +			reg = <0 0x40>;
>> +			brcm,tmon-mask = <0x3f>;
>> +			brcm,max-crit-temp = <105000>;
>> +		};
>> +	};
>> -- 
>> 2.7.4
>>


-- 
Florian