Re: [PATCH] samples: disable CONFIG_SAMPLES for UML

[Masahiro Yamada]

2018å9æ19æ(æ) 15:58 Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>:
>
> Hi.
>
> 2018-09-18 17:21 GMT+09:00 Richard Weinberger <richard@xxxxxx>:
> > Am Dienstag, 18. September 2018, 05:58:33 CEST schrieb Masahiro Yamada:
> >> Some samples require headers installation, so commit 3fca1700c4c3
> >> ("kbuild: make samples really depend on headers_install") added
> >> such dependency in the top Makefile.  However, UML fails to build
> >> with CONFIG_SAMPLES=y because UML does not support headers_install.
> >>
> >> Fixes: 3fca1700c4c3 ("kbuild: make samples really depend on headers_install")
> >> Reported-by: Kees Cook <keescook@xxxxxxxxxxxx>
> >> Cc: David Howells <dhowells@xxxxxxxxxx>
> >> Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
> >
> > Is there anything UML can do better?
> > Not sure whether an arch like is supposed to install headers at all,
> > I guess no. :)
>
> I just thought suppressing CONFIG_SAMPLES was a big hammer.
>
> We could install host-arch headers for UML if we like,
> but I am not sure whether is is sensible...
>
> Wait for comments in case somebody has a better solution.
>


I started to think this is a wrong hack.


I posted a different solution:
https://patchwork.kernel.org/patch/10619043/



-- 
Best Regards
Masahiro Yamada