Re: [PATCH v11 26/26] s390: doc: detailed specifications for AP virtualization

[Christian Borntraeger]

On 09/27/2018 09:19 PM, Tony Krowiak wrote:
> On 09/26/2018 06:42 PM, Alex Williamson wrote:
>> On Tue, 25 Sep 2018 19:16:41 -0400
>> Tony Krowiak <akrowiak@xxxxxxxxxxxxxxxxxx> wrote:
>>
>>> From: Tony Krowiak <akrowiak@xxxxxxxxxxxxx>
>>>
>>> This patch provides documentation describing the AP architecture and
>>> design concepts behind the virtualization of AP devices. It also
>>> includes an example of how to configure AP devices for exclusive
>>> use of KVM guests.
>>>
>>> Signed-off-by: Tony Krowiak <akrowiak@xxxxxxxxxxxxx>
>>> Reviewed-by: Halil Pasic <pasic@xxxxxxxxxxxxx>
>>> ---
>>> Â Documentation/s390/vfio-ap.txt | 782 +++++++++++++++++++++++++++++++++
>>> Â MAINTAINERSÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ |ÂÂ 1 +
>>> Â 2 files changed, 783 insertions(+)
>>> Â create mode 100644 Documentation/s390/vfio-ap.txt
>> ...
>>> +Example:
>>> +=======
>>> +Let's now provide an example to illustrate how KVM guests may be given
>>> +access to AP facilities. For this example, we will show how to configure
>>> +three guests such that executing the lszcrypt command on the guests would
>>> +look like this:
>>> +
>>> +Guest1
>>> +------
>>> +CARD.DOMAIN TYPEÂ MODE
>>> +------------------------------
>>> +05ÂÂÂÂÂÂÂÂÂ CEX5C CCA-Coproc
>>> +05.0004ÂÂÂÂ CEX5C CCA-Coproc
>>> +05.00abÂÂÂÂ CEX5C CCA-Coproc
>>> +06ÂÂÂÂÂÂÂÂÂ CEX5A Accelerator
>>> +06.0004ÂÂÂÂ CEX5A Accelerator
>>> +06.00abÂÂÂÂ CEX5C CCA-Coproc
>>> +
>>> +Guest2
>>> +------
>>> +CARD.DOMAIN TYPEÂ MODE
>>> +------------------------------
>>> +05ÂÂÂÂÂÂÂÂÂ CEX5A Accelerator
>>> +05.0047ÂÂÂÂ CEX5A Accelerator
>>> +05.00ffÂÂÂÂ CEX5A Accelerator (5,4), (5,171), (6,4), (6,171),
>> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>> Seems like an unfinished thought here.

Can you submit another fixup that takes care of this comment?