Re: [PATCH v3] staging: ks7010: Add null pointer check for skb

From: Dan Carpenter
Date: Fri Sep 28 2018 - 04:13:45 EST


You might want to try running Smatch on your patches. This is the
second one where maybe the results would have been interesting.

git clone http://repo.or.cz/w/smatch.git
cd smatch
make
cd ~/kernel/src/
~/smatch/smatch_scripts/kchecker drivers/staging/ks7010/ks_hostif.c

This patch introduced a problem, but the earlier one fixed a potential
problem in rtl8723bs:

drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:1274 OnAssocReq() error: uninitialized symbol 'ie_len'.

Unfortunately, Smatch missed the potential NULL dereference in
OnAssocReq()... It wouldn't be that hard to fix...

regards,
dan carpenter