Re: [PATCH v7 02/14] sched/cpufreq: Prepare schedutil for Energy Aware Scheduling
From: Rafael J. Wysocki
Date: Fri Sep 28 2018 - 04:38:32 EST
On Friday, September 28, 2018 10:35:05 AM CEST Quentin Perret wrote:
> Hi Rafael,
>
> On Friday 28 Sep 2018 at 10:23:42 (+0200), Rafael J. Wysocki wrote:
> [...]
> > OK, so please document the enum type.
>
> Will do.
>
> [...]
> > Documenting things properly is absolutely required.
>
> Understood.
>
> > The other changes suggested by me are rather straightforward, so why would it
> > be a problem to make them right away if you agree to make them?
>
> Right, if I need to spin a v8 for doc purpose anyway, I guess I can do
> the other small fixes at the same time.
>
> I'll wait a bit before sending the update to see if others have some
> feedback. It's probably a bit late for 4.20 anyway ... Or is it not ?
I think this is scheduler material anyway, even though it affects cpufreq
somewhat, so that depends on what Peter thinks really.
Thanks,
Rafael