Re: [PATCH] printk: inject caller information into the body of message

From: Sergey Senozhatsky
Date: Fri Sep 28 2018 - 05:02:12 EST


On (09/28/18 01:10), Tetsuo Handa wrote:
>
> Therefore, I think that "Either we need to require synchronization - umm... and
> document it - or to provide some means of synchronization in pr_line()." is a
> pointless worry. It is only existing printk() API which needs synchronization. I
> think that line buffered printk() API does not need to talk about synchronization.
> Just saying "don't share DEFINE_PR_LINE()/DEFINE_PR_LINE_BUF() variables" will be
> sufficient.

Agreed. My conclusion at the end was that - "pr_line is going to do as much
as seq_buf does". So pr_line won't provide any additional synchronization
mechanisms.

-ss