Re: [PATCH v2 7/7] ia64: add __IGNORE* entries in asm/unistd.h

From: Arnd Bergmann
Date: Fri Sep 28 2018 - 08:09:51 EST


On Thu, Sep 27, 2018 at 4:16 PM Firoz Khan <firoz.khan@xxxxxxxxxx> wrote:
>
> Add __IGNORE* entries for perf_event_open, seccomp, pkey_
> mprotect, pkey_alloc, pkey_free, statx, io_pgetevents and
> rseq in the file asm/unistd.h as it is correct to keep
> __IGNORE* entry in non uapi header asm/unistd.h while uapi/
> asm/unistd.h must hold information only useful for user
> space applications.
>
> Signed-off-by: Firoz Khan <firoz.khan@xxxxxxxxxx>
> ---

This patch looks wrong: We don't want to ignore the fact that the
syscalls are missing here, we should add them instead. I'd leave
that for a follow-up though, we may want to add further ones that
are currently marked as __IGNORE.

Arnd