Re: [PATCH v2] powerpc: wire up memtest

From: Daniel Axtens
Date: Fri Sep 28 2018 - 10:30:34 EST


Hi Christophe,

> Add call to early_memtest() so that kernel compiled with
> CONFIG_MEMTEST really perform memtest at startup when requested
> via 'memtest' boot parameter.
>
This works for me on an e6500.

Tested-by: Daniel Axtens <dja@xxxxxxxxxx>

However, you should also change Documentation/admin-guide/kernel-parameters.txt
to reflect that memtest is supported natively on ppc with your patch.

Regards,
Daniel

> Signed-off-by: Christophe Leroy <christophe.leroy@xxxxxx>
> ---
> v2: moved the test after initmem_init() as PPC64 sets max_low_pfn later than PPC32.
>
> arch/powerpc/kernel/setup-common.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/powerpc/kernel/setup-common.c b/arch/powerpc/kernel/setup-common.c
> index 93fa0c99681e..9ca9db707bcb 100644
> --- a/arch/powerpc/kernel/setup-common.c
> +++ b/arch/powerpc/kernel/setup-common.c
> @@ -33,6 +33,7 @@
> #include <linux/serial_8250.h>
> #include <linux/percpu.h>
> #include <linux/memblock.h>
> +#include <linux/bootmem.h>
> #include <linux/of_platform.h>
> #include <linux/hugetlb.h>
> #include <asm/debugfs.h>
> @@ -966,6 +967,8 @@ void __init setup_arch(char **cmdline_p)
>
> initmem_init();
>
> + early_memtest(min_low_pfn << PAGE_SHIFT, max_low_pfn << PAGE_SHIFT);
> +
> #ifdef CONFIG_DUMMY_CONSOLE
> conswitchp = &dummy_con;
> #endif
> --
> 2.13.3