Re: [PATCH V6 04/33] csky: Exception handling and mm-fault
From: Christoph Hellwig
Date: Fri Sep 28 2018 - 12:15:15 EST
> +#ifndef CONFIG_CPU_HAS_TLBI
> + /*
> + * We fault-in kernel-space virtual memory on-demand. The
> + * 'reference' page table is init_mm.pgd.
> + *
> + * NOTE! We MUST NOT take any locks for this case. We may
> + * be in an interrupt or a critical region, and should
> + * only copy the information from the master page table,
> + * nothing more.
> + */
> + if (unlikely(address >= VMALLOC_START && address <= VMALLOC_END))
> + {
This doesn't fir the kernel style. Please run checkpatch.pl over
your code and fix at least all warnings that don't seem clearly bogus.