Re: [PATCH security-next v3 00/29] LSM: Explict LSM ordering

[Stephen Smalley]

On 09/28/2018 04:25 PM, Stephen Smalley wrote:
> On 09/28/2018 04:01 PM, Kees Cook wrote:
> > On Fri, Sep 28, 2018 at 8:55 AM, Casey Schaufler 
> > <casey@xxxxxxxxxxxxxxxx> wrote:
> > > On 9/24/2018 5:18 PM, Kees Cook wrote:
> > > > v3:
> > > > - add CONFIG_LSM_ENABLE and refactor resulting logic
> > >
> > > Kees, you can add my
> > >
> > > ÂÂÂÂÂÂÂÂ Reviewed-by:Casey Schaufler <casey@xxxxxxxxxxxxxxxx>
> > >
> > > for this entire patch set. Thank you for taking this on, it's
> > > a significant and important chunk of the LSM infrastructure
> > > update.
> >
> > Thanks!
> >
> > John, you'd looked at this a bit too -- do the results line up with
> > your expectations?
> >
> > Any thoughts from SELinux, TOMOYO, or IMA folks?
>
> What's it relative to? First patch fails for me on current security/next.

Never mind - user error ;)

> Is there a branch in your repo that has the v3 patches?

But still wondered about this one.

> > -Kees
> >
> > > > ...
> > > > Breakdown of patches:
> > > >
> > > > Infrastructure improvements (no logical changes):
> > > > ÂÂ LSM: Correctly announce start of LSM initialization
> > > > ÂÂ vmlinux.lds.h: Avoid copy/paste of security_init section
> > > > ÂÂ LSM: Rename .security_initcall section to .lsm_info
> > > > ÂÂ LSM: Remove initcall tracing
> > > > ÂÂ LSM: Convert from initcall to struct lsm_info
> > > > ÂÂ vmlinux.lds.h: Move LSM_TABLE into INIT_DATA
> > > > ÂÂ LSM: Convert security_initcall() into DEFINE_LSM()
> > > > ÂÂ LSM: Record LSM name in struct lsm_info
> > > > ÂÂ LSM: Provide init debugging infrastructure
> > > > ÂÂ LSM: Don't ignore initialization failures
> > > >
> > > > Split "integrity" out into "ordered initialization" (no logical 
> > > > changes):
> > > > ÂÂ LSM: Introduce LSM_FLAG_LEGACY_MAJOR
> > > > ÂÂ LSM: Provide separate ordered initialization
> > > >
> > > > Provide centralized LSM enable/disable infrastructure:
> > > > ÂÂ LoadPin: Rename "enable" to "enforce"
> > > > ÂÂ LSM: Plumb visibility into optional "enabled" state
> > > > ÂÂ LSM: Lift LSM selection out of individual LSMs
> > > > ÂÂ LSM: Prepare for arbitrary LSM enabling
> > > > ÂÂ LSM: Introduce CONFIG_LSM_ENABLE
> > > > ÂÂ LSM: Introduce lsm.enable= and lsm.disable=
> > > > ÂÂ LSM: Prepare for reorganizing "security=" logic
> > > > ÂÂ LSM: Refactor "security=" in terms of enable/disable
> > > >
> > > > Provide centralized LSM ordering infrastructure:
> > > > ÂÂ LSM: Build ordered list of ordered LSMs for init
> > > > ÂÂ LSM: Introduce CONFIG_LSM_ORDER
> > > > ÂÂ LSM: Introduce "lsm.order=" for boottime ordering
> > > >
> > > > Move minor LSMs into ordered LSM initialization:
> > > > ÂÂ LoadPin: Initialize as ordered LSM
> > > > ÂÂ Yama: Initialize as ordered LSM
> > > > ÂÂ LSM: Introduce enum lsm_order
> > > > ÂÂ capability: Initialize as LSM_ORDER_FIRST
> > > >
> > > > Move major LSMs into ordered LSM initialization:
> > > > ÂÂ LSM: Separate idea of "major" LSM from "exclusive" LSM
> > > > ÂÂ LSM: Add all exclusive LSMs to ordered initialization
> > > >
> > > > -Kees
> > > >
> > > > Â .../admin-guide/kernel-parameters.txtÂÂÂÂÂÂÂÂ |Â 20 +
> > > > Â arch/arc/kernel/vmlinux.lds.SÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ |ÂÂ 1 -
> > > > Â arch/arm/kernel/vmlinux-xip.lds.SÂÂÂÂÂÂÂÂÂÂÂÂ |ÂÂ 1 -
> > > > Â arch/arm64/kernel/vmlinux.lds.SÂÂÂÂÂÂÂÂÂÂÂÂÂÂ |ÂÂ 1 -
> > > > Â arch/h8300/kernel/vmlinux.lds.SÂÂÂÂÂÂÂÂÂÂÂÂÂÂ |ÂÂ 1 -
> > > > Â arch/microblaze/kernel/vmlinux.lds.SÂÂÂÂÂÂÂÂÂ |ÂÂ 2 -
> > > > Â arch/powerpc/kernel/vmlinux.lds.SÂÂÂÂÂÂÂÂÂÂÂÂ |ÂÂ 2 -
> > > > Â arch/um/include/asm/common.lds.SÂÂÂÂÂÂÂÂÂÂÂÂÂ |ÂÂ 2 -
> > > > Â arch/xtensa/kernel/vmlinux.lds.SÂÂÂÂÂÂÂÂÂÂÂÂÂ |ÂÂ 1 -
> > > > Â include/asm-generic/vmlinux.lds.hÂÂÂÂÂÂÂÂÂÂÂÂ |Â 25 +-
> > > > Â include/linux/init.hÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ |ÂÂ 2 -
> > > > Â include/linux/lsm_hooks.hÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ |Â 43 ++-
> > > > Â include/linux/module.hÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ |ÂÂ 1 -
> > > > Â security/KconfigÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ |Â 61 ++-
> > > > Â security/apparmor/lsm.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ |Â 16 +-
> > > > Â security/commoncap.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ |ÂÂ 8 +-
> > > > Â security/integrity/iint.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ |ÂÂ 5 +-
> > > > Â security/loadpin/KconfigÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ |ÂÂ 4 +-
> > > > Â security/loadpin/loadpin.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ |Â 28 +-
> > > > Â security/security.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ | 351 
> > > > +++++++++++++++---
> > > > Â security/selinux/hooks.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ |Â 16 +-
> > > > Â security/smack/smack_lsm.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ |ÂÂ 8 +-
> > > > Â security/tomoyo/tomoyo.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ |ÂÂ 7 +-
> > > > Â security/yama/yama_lsm.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ |ÂÂ 7 +-
> > > > Â 24 files changed, 438 insertions(+), 175 deletions(-)