Re: Bad MAINTAINERS pattern in section 'STAGING - FLARION FT1000 DRIVERS'

From: Joe Perches
Date: Fri Sep 28 2018 - 21:16:00 EST


On Fri, 2018-09-28 at 17:46 -0700, Greg Kroah-Hartman wrote:
> On Fri, Sep 28, 2018 at 03:04:23PM -0700, Joe Perches wrote:
> > Please fix this defect appropriately.
> >
> > linux-next MAINTAINERS section:
> >
> > 13899 STAGING - FLARION FT1000 DRIVERS
> > 13900 M: Marek Belisko <marek.belisko@xxxxxxxxx>
> > 13901 S: Odd Fixes
> > --> 13902 F: drivers/staging/ft1000/
> >
> > Commit that introduced this:
> >
> > commit a0138163cfbfdfbdc20e4477c77bd7046bd66bb4
> > Author: Joe Perches <joe@xxxxxxxxxxx>
> > Date: Tue Jul 5 15:21:34 2011 -0700
> >
> > MAINTAINERS: Add remaining staging entries
> >
> > Add the staging entries from various TODO files
> > to MAINTAINERS. Add a few web links as well.
> >
> > Miscellaneous staging typo section header fix.
> >
> > Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
> >
> > MAINTAINERS | 69 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
> > 1 file changed, 68 insertions(+), 1 deletion(-)
>
> So you are going to fix this, considering you created the problem?

_I_ did not create this problem.

You neglected to read the commit information below this in the
parent email.

When I wrote the MAINTAINERS patch in 2011, the files existed.

The files were removed in 2015 and you signed-off on their removal.

----------------------------------------------
Last commit with drivers/staging/ft1000/

commit 6512edec48b2ccfe9bb969ce26ebbbcd49de6c4b
Author: Deepa Dinamani <deepa.kernel@xxxxxxxxx>
Date: Wed Oct 21 18:42:37 2015 -0700

staging: ft1000: remove obsolete driver

Remove support for Qleadtek Flash-OFDM modems. Telecom carrier is
discontinuing service for the radio technology.
See http://www.gtigroup.org/news/ind/2015-08-18/6996.html.

Suggested-by: Arnd Bergmann <arnd@xxxxxxxx>
Signed-off-by: Deepa Dinamani <deepa.kernel@xxxxxxxxx>
Acked-by: Arnd Bergmann <arnd@xxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
----------------------------------------------

> This is an odd request to make of yourself in public, or was this a
> script gone wrong?

It was not a script gone wrong, though the output and emails
were scripted.

> confused,

No worries, it's easy to miss stuff.

fyi: the silly script I wrote is attached

Done using the latest -next with an empty patterns directory

$ perl ./scripts/get_maintainer.pl --self-test=patterns | \
cut -f2 -d: | \
while read line ; do \
perl ./dump_section.perl $line \
done

Attachment: dump_section.perl
Description: Perl program