Re: [PATCH] i2c: brcmstb: Allow enabling the driver on DSL SoCs

From: Geert Uytterhoeven
Date: Sat Sep 29 2018 - 03:56:13 EST


Hi Florian,

On Sat, Sep 29, 2018 at 12:40 AM Florian Fainelli <f.fainelli@xxxxxxxxx> wrote:
> ARCH_BCM_63XX which is used by ARM-based DSL SoCs from Broadcom uses the
> same controller, make it possible to select the STB driver and update
> the Kconfig and help text a bit.
>
> Signed-off-by: Florian Fainelli <f.fainelli@xxxxxxxxx>

Thanks for your patch!

> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -432,12 +432,13 @@ config I2C_BCM_KONA
> If you do not need KONA I2C interface, say N.
>
> config I2C_BRCMSTB
> - tristate "BRCM Settop I2C controller"
> - depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
> + tristate "BRCM Settop/DSL I2C controller"
> + depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST || \
> + ARCH_BCM_63XX

I think it would be good to keep the "|| COMPILE_TEST" as the last dependency.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds