Re: [REVIEW][PATCH 0/3] signal/unicore32: siginfo cleanups

[Guan Xuetao]

Hi Eric,

I'll review and check the patches after chinese national day vocation.

Thanks.

Guan Xuetao

> -----Original Messages-----
> From: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>
> Sent Time: 2018-09-24 23:23:35 (Monday)
> To: linux-kernel@xxxxxxxxxxxxxxx
> Cc: linux-arch@xxxxxxxxxxxxxxx, "Guan Xuetao" <gxt@xxxxxxxxxx>
> Subject: [REVIEW][PATCH 0/3] signal/unicore32: siginfo cleanups
> 
> 
> I have been slowly cleaning up the architectues ever since I discovered
> that the pattern of passing in struct siginfo is error prone, and
> occassionally results in broken siginfo being sent to userspace.
> 
> I don't have a clue how to obtain a working unicore32 compiler so the
> following changes have only been reviewed carefully and not compile
> tested.  Still I believe they are simple and obviously correct.
> 
> Anyone who can review or test these changes please do and let me know
> about any problems you find so that I can correct them.
> 
> My intention is to merge this through my siginfo tree.  If you feel it
> should go through your arch tree let me know.   All of the prerequisites
> should have been merged several releases ago.
> 
> Eric W. Biederman (3):
>       signal/unicore32: Use send_sig_fault where appropriate
>       signal/unicore32: Generate siginfo in ucs32_notify_die
>       signal/unicore32: Use force_sig_fault where appropriate
> 
>  arch/unicore32/include/asm/bug.h  |  3 ++-
>  arch/unicore32/kernel/fpu-ucf64.c | 12 +++---------
>  arch/unicore32/kernel/traps.c     |  5 +++--
>  arch/unicore32/mm/fault.c         | 27 +++++----------------------
>  4 files changed, 13 insertions(+), 34 deletions(-)
> 
> Eric