Re: [PATCH v2 2/3] hwmon: ina3221: Fix INA3221_CONFIG_MODE macros

[Guenter Roeck]

On Sat, Sep 29, 2018 at 02:44:06PM -0700, Nicolin Chen wrote:
> The three INA3221_CONFIG_MODE macros are not correctly defined here.
> The MODE3-1 filed is loacted at BIT 2-0 according to the datasheet.
> 
located

> So this patch just fixes them by shifting all of them with a correct
> offset. However, this isn't a crital bug fix as the driver does not
> use any of them at this point.
> 
> Signed-off-by: Nicolin Chen <nicoleotsuka@xxxxxxxxx>

No need to resend; I fixed it up. Applied to hwmon-next.

Thanks,
Guenter

> ---
>  drivers/hwmon/ina3221.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/hwmon/ina3221.c b/drivers/hwmon/ina3221.c
> index cfe65ff01051..e0c4f4d83f4e 100644
> --- a/drivers/hwmon/ina3221.c
> +++ b/drivers/hwmon/ina3221.c
> @@ -38,9 +38,9 @@
>  #define INA3221_WARN3			0x0c
>  #define INA3221_MASK_ENABLE		0x0f
>  
> -#define INA3221_CONFIG_MODE_SHUNT	BIT(1)
> -#define INA3221_CONFIG_MODE_BUS		BIT(2)
> -#define INA3221_CONFIG_MODE_CONTINUOUS	BIT(3)
> +#define INA3221_CONFIG_MODE_SHUNT	BIT(0)
> +#define INA3221_CONFIG_MODE_BUS		BIT(1)
> +#define INA3221_CONFIG_MODE_CONTINUOUS	BIT(2)
>  
>  #define INA3221_RSHUNT_DEFAULT		10000
>