Re: [PATCH 4/5] fpga: of-fpga-region: Use platform_set_drvdata

[Greg Kroah-Hartman]

On Wed, Sep 12, 2018 at 09:43:26AM -0500, Alan Tull wrote:
> From: Moritz Fischer <mdf@xxxxxxxxxx>
> 
> Use platform_set_drvdata rather than dev_set_drvdata
> to match the platform_get_drvdata in the _remove()
> function of the platform driver.
> 
> Signed-off-by: Moritz Fischer <mdf@xxxxxxxxxx>
> Acked-by: Alan Tull <atull@xxxxxxxxxx>
> ---
>  drivers/fpga/of-fpga-region.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/fpga/of-fpga-region.c b/drivers/fpga/of-fpga-region.c
> index 052a134..d6a70e4 100644
> --- a/drivers/fpga/of-fpga-region.c
> +++ b/drivers/fpga/of-fpga-region.c
> @@ -421,7 +421,7 @@ static int of_fpga_region_probe(struct platform_device *pdev)
>  		goto eprobe_free;
>  
>  	of_platform_populate(np, fpga_region_of_match, NULL, &region->dev);
> -	dev_set_drvdata(dev, region);
> +	platform_set_drvdata(pdev, region);

Again, not really a bugfix :)