Re: [PATCH V7 3/8] clocksource: add C-SKY SMP timer

From: Guo Ren
Date: Sun Sep 30 2018 - 20:02:47 EST


On Sun, Sep 30, 2018 at 09:22:30PM +0200, Daniel Lezcano wrote:
> On 30/09/2018 18:18, Guo Ren wrote:
> > This timer is used by SMP system and use mfcr/mtcr instruction
> > to access the regs.
> >
> > Changelog:
> > - Remove #define CPUHP_AP_CSKY_TIMER_STARTING
> > - Add CPUHP_AP_CSKY_TIMER_STARTING in cpuhotplug.h
> > - Support csky mp timer alpha version.
> > - Just use low-counter with 32bit width as clocksource.
> > - Coding convention with upstream feed-back.
> >
> > Signed-off-by: Guo Ren <ren_guo@xxxxxxxxx>
> > ---
>
>
> Guo,
>
> what is the flow of your patches ?
>
> You sent me a V8 with two patches and those timers which I commented.
>
> And now there is this V7 with the patches previously sent as V8 without
> the comments take into account.
>
> I'm a bit lost. Can you clarify ?
Opps ... I should send the "V9 C-SKY(csky) Linux Drivers". It's a wrong
patchset from "V6 C-SKY(csky) Linux Kernel Port".

The patchset didn't include your comment in V8:
- Add COMIPLE_TEST in Kconfig
- no cast is needed for "struct clock_event_device *ce = dev"
- remove: extra space after (u64).

I'm sorry about it, I'll send "V9 C-SKY(csky) Linux Drivers". My fault.

Best Regards
Guo Ren