Re: [PATCH v2 6/7] ia64: uapi header and system call table file generation

From: Firoz Khan
Date: Mon Oct 01 2018 - 10:16:09 EST


Hi Arnd,

On Fri, 28 Sep 2018 at 17:40, Arnd Bergmann <arnd@xxxxxxxx> wrote:
>
> On Thu, Sep 27, 2018 at 4:16 PM Firoz Khan <firoz.khan@xxxxxxxxxx> wrote:
>
> > +#include <asm/syscall_table.h>
> > .org sys_call_table + 8*NR_syscalls // guard against failures to increase NR_syscalls
> > +#undef __SYSCALL
>
> This part looks odd: according to the comment, this should only guard against
> the table getting out of sync. However, with the script, that will never happen.

Thanks for pointing it out this error.

- Firoz
>
> Arnd