Re: [PATCH] rsi: Remove unnecessary boolean condition

From: Kalle Valo
Date: Mon Oct 01 2018 - 11:32:05 EST


Nathan Chancellor <natechancellor@xxxxxxxxx> wrote:

> Clang warns that the address of a pointer will always evaluated as true
> in a boolean context.
>
> drivers/net/wireless/rsi/rsi_91x_mac80211.c:927:50: warning: address of
> array 'key->key' will always evaluate to 'true'
> [-Wpointer-bool-conversion]
> if (vif->type == NL80211_IFTYPE_STATION && key->key &&
> ~~ ~~~~~^~~
> 1 warning generated.
>
> Link: https://github.com/ClangBuiltLinux/linux/issues/136
> Signed-off-by: Nathan Chancellor <natechancellor@xxxxxxxxx>

Patch applied to wireless-drivers-next.git, thanks.

f613e4803dd6 rsi: Remove unnecessary boolean condition

--
https://patchwork.kernel.org/patch/10609513/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches