Re: [PATCH 3/3] kbuild: add -Wno-unused-but-set-variable compiler flag unconditionally

[Masahiro Yamada]

Hi Nick,

2018å10æ2æ(ç) 2:18 Nick Desaulniers <ndesaulniers@xxxxxxxxxx>:
>
> On Mon, Oct 1, 2018 at 2:45 AM Masahiro Yamada
> <yamada.masahiro@xxxxxxxxxxxxx> wrote:
> >
> > We have raised the compiler requirement from time to time.
> > With commit cafa0010cd51 ("Raise the minimum required gcc version
> > to 4.6"), the minimum for GCC is 4.6 now.
> >
> > This flag was added by GCC 4.6, and it is recognized by Clang and
> > ICC as well.
>
> This doesn't seem to be the case for Clang:
> https://godbolt.org/z/qesF5o
>
> Nacked-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>

Hmm, I tested this patch with pre-built Clang 6.0.1 / 7.0.0
downloaded from http://releases.llvm.org/download.html

Was this option dropped by clang 8 ?


>
> >
> > Let's rip off the cc-disable-warning switch, and see if somebody
> > complains about it.
> >
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
> > ---
> >
> >  Makefile | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Makefile b/Makefile
> > index 8a23fee..2627266 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -716,7 +716,7 @@ else
> >
> >  # These warnings generated too much noise in a regular build.
> >  # Use make W=1 to enable them (see scripts/Makefile.extrawarn)
> > -KBUILD_CFLAGS += $(call cc-disable-warning, unused-but-set-variable)
> > +KBUILD_CFLAGS += -Wno-unused-but-set-variable
> >  endif
> >
> >  KBUILD_CFLAGS += $(call cc-disable-warning, unused-const-variable)
> > --
> > 2.7.4
> >
>
>
> --
> Thanks,
> ~Nick Desaulniers



-- 
Best Regards
Masahiro Yamada