Re: [PATCH security-next v3 04/29] LSM: Remove initcall tracing

[Kees Cook]

On Mon, Oct 1, 2018 at 2:23 PM, Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> On Mon, 1 Oct 2018 14:07:55 -0700
> John Johansen <john.johansen@xxxxxxxxxxxxx> wrote:
>
>> On 09/24/2018 05:18 PM, Kees Cook wrote:
>> > This partially reverts commit 58eacfffc417 ("init, tracing: instrument
>> > security and console initcall trace events") since security init calls
>> > are about to no longer resemble regular init calls.
>> >
>> > Cc: James Morris <jmorris@xxxxxxxxx>
>> > Cc: "Serge E. Hallyn" <serge@xxxxxxxxxx>
>> > Cc: Abderrahmane Benbachir <abderrahmane.benbachir@xxxxxxxxxx>
>> > Cc: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>
>> > Cc: linux-security-module@xxxxxxxxxxxxxxx
>> > Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
>>
>>
>> Reviewed-by: John Johansen <john.johansen@xxxxxxxxxxxxx>
>>
>> though I do think it would be a good idea to add a new set
>> of trace points, but that can come as a separate patch
>>
>>
>
> Agreed.

BTW, how would this look? I'm not familiar with adding new tracepoints...

-Kees

-- 
Kees Cook
Pixel Security