Re: [PATCH net-next] hv_netvsc: Fix rndis_per_packet_info internal field initialization

From: David Miller
Date: Tue Oct 02 2018 - 02:15:44 EST


From: Haiyang Zhang <haiyangz@xxxxxxxxxxxxxxxxx>
Date: Fri, 28 Sep 2018 14:41:23 +0000

> From: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>
>
> The RSC feature -- a bit field "internal" was added here with total
> size unchanged:
> struct rndis_per_packet_info {
> u32 size;
> u32 type:31;
> u32 internal:1;
> u32 ppi_offset;
> };
>
> On TX path, we put rndis msg into skb head room, which is not zeroed
> before passing to us. We do not use the "internal" field in TX path,
> but it may impact older hosts which use the entire 32 bits as "type".
>
> To fix the bug, this patch sets the field "internal" to zero.
>
> Fixes: c8e4eff4675f ("hv_netvsc: Add support for LRO/RSC in the vSwitch")
> Signed-off-by: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>

Applied.