Re: [PATCH v2] i2c: brcmstb: Allow enabling the driver on DSL SoCs

From: Andy Shevchenko
Date: Tue Oct 02 2018 - 06:28:07 EST


On Tue, Oct 2, 2018 at 1:22 PM Arnd Bergmann <arnd@xxxxxxxx> wrote:
>
> On Mon, Oct 1, 2018 at 8:13 PM Andy Shevchenko
> <andy.shevchenko@xxxxxxxxx> wrote:
> > On Mon, Oct 1, 2018 at 8:44 PM Florian Fainelli <f.fainelli@xxxxxxxxx> wrote:
> > >
> > > config I2C_BRCMSTB
> > > - tristate "BRCM Settop I2C controller"
> > > - depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
> > > + tristate "BRCM Settop/DSL I2C controller"
> > > + depends on ARCH_BRCMSTB || BMIPS_GENERIC || ARCH_BCM_63XX || \
> > > + COMPILE_TEST
> >
> > I would rather split this to two 'depends' entries, though it's
> > cosmetic and up to you.
>
> You can only split 'depends on A && B' into multiple lines, not
> 'depends on A || B'.

Indeed. What I was thinking of?

--
With Best Regards,
Andy Shevchenko