Re: [PATCH v2 3/5] x86: pgtable: Drop pXd_none() checks from pXd_free_pYd_table()

From: Thomas Gleixner
Date: Tue Oct 02 2018 - 07:31:05 EST


On Tue, 2 Oct 2018, Will Deacon wrote:

Subject prefix wants to be 'x86/pgtable:' please

> Now that the core code checks this for us, we don't need to do it in the
> backend.

According to Documentation changelogs want to be written in imperative
mood.

The core code has a check for pXd_none() already. Remove it in the
architecture implementation.

Or something like that.

> Cc: Chintan Pandya <cpandya@xxxxxxxxxxxxxx>
> Cc: Toshi Kani <toshi.kani@xxxxxxx>
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: Michal Hocko <mhocko@xxxxxxxx>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Reviewed-by: Toshi Kani <toshi.kani@xxxxxxx>
> Signed-off-by: Will Deacon <will.deacon@xxxxxxx>

Other than the nits above:

Acked-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>