Re: [PATCH v3 3/3] gpiolib: Show correct direction from the beginning

From: Timur Tabi
Date: Tue Oct 02 2018 - 08:29:51 EST


On 10/2/18 3:27 AM, Ricardo Ribalda Delgado wrote:
+ /* REVISIT: most hardware initializes GPIOs as inputs (often
+ * with pullups enabled) so power usage is minimized. Linux
+ * code should set the gpio direction first thing; but until
+ * it does, and in case chip->get_direction is not set, we may
+ * expose the wrong direction in sysfs.
+ */

I don't think this comment applies any more.

Also, please don't use timur@xxxxxxxxxxxxxx any more. That address is no longer valid. Use timur@xxxxxxxxxx instead.