Re: [PATCH 1/2] x86/platform/uv: Add is_early_uv_system check

[Mike Travis]

On 10/1/2018 11:20 PM, Thomas Gleixner wrote:
> On Mon, 1 Oct 2018, Mike Travis wrote:
>
> > Introduce is_early_uv_system() which uses efi.uv_systab to decide early
> > in the boot process whether we're on a UV system.
> >
> > This is needed to skip other early setup/init code that might break UV
> > platform if done too early such as before necessary ACPI tables parsing
> > takes place.
> >
> > Signed-off-by: Mike Travis <mike.travis@xxxxxxx>
> > Signed-off-by: Hedi Berriche <hedi.berriche@xxxxxxx>
>
> This SOB chain is wrong. I don't see how Hedi is involved in this. If this
> wants to express that the patch was developed together please see
> Documentation for the Co-developed-by tag.

Hedi suggested a "Suggested-by:" tag, would that suffice?
> > Reviewed-by: Russ Anderson <rja@xxxxxxx>
> > Reviewed-by: Dimitri Sivanich <sivanich@xxxxxxx>
> > ---
> >   arch/x86/include/asm/uv/uv.h |    6 ++++++
> >   1 file changed, 6 insertions(+)
> >
> > --- linux.orig/arch/x86/include/asm/uv/uv.h
> > +++ linux/arch/x86/include/asm/uv/uv.h
> > @@ -10,8 +10,13 @@ struct cpumask;
> >   struct mm_struct;
> >   
> >   #ifdef CONFIG_X86_UV
> > +#include <linux/efi.h>
> >   
> >   extern enum uv_system_type get_uv_system_type(void);
> > +static inline int is_early_uv_system(void)
>
> Can you please make this bool?
>
> > +{
> > +	return !((efi.uv_systab == EFI_INVALID_TABLE_ADDR) || !efi.uv_systab);
> > +}
>
> Thanks,
>
> 	tglx