Re: [PATCH v5 1/2] dt-bindings: spi: Qualcomm Quad SPI(QSPI) documentation

[Doug Anderson]

Hi,
On Mon, Oct 1, 2018 at 6:32 PM Ryan Case <ryandcase@xxxxxxxxxxxx> wrote:
>
> From: Girish Mahadevan <girishm@xxxxxxxxxxxxxx>
>
> Bindings for Qualcomm Quad SPI used on SoCs such as sdm845.
>
> Signed-off-by: Girish Mahadevan <girishm@xxxxxxxxxxxxxx>
> Signed-off-by: Ryan Case <ryandcase@xxxxxxxxxxxx>
> ---
>
> Changes in v5:
> - None
>
> Changes in v4:
> - Changed qspi@ to spi@ and device@ to flash@ to match Rob's review

Rob said that with those changes you could add his reviewed by [1], so
this patch should have carried:

Reviewed-by: Rob Herring <robh@xxxxxxxxxx>

I'd also say that usually when changes are minor you can make a
judgement call and carry previous reviews.  If there's any question
about whether previous reviews can be carried you can mention it
somewhere in your changelog.  In this particular case I would have
called the changes minor / non-controversial so I would have kept
Stephen and my reviews when posting the new patch.  In any case
Stephen has already re-provided his review and you can feel free to
add:

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>


[1] https://lkml.kernel.org/r/20180927204624.GA7072@bogus