Re: [PATCH v5 7/8] tracing: Add hist trigger onchange() handler

[Tom Zanussi]

Hi Masami,

On Tue, 2018-10-02 at 16:53 +0900, Masami Hiramatsu wrote:
> On Mon,  1 Oct 2018 11:18:07 -0500
> Tom Zanussi <zanussi@xxxxxxxxxx> wrote:
> 
> > From: Tom Zanussi <tom.zanussi@xxxxxxxxxxxxxxx>
> > 
> > Add support for a hist:onchange($var) handler, similar to the
> > onmax()
> > handler but triggering whenever there's any change in $var, not
> > just a
> > max.
> > 
> > Also, add a testcase for it.
> 
> Could you separate the testcase and document update from this patch,
> since those are maintained in different trees?
> 

OK, will do.

> And also, could you update <tracefs>/README so that the testcase can
> ensure the kernel supports this feature? Since the testcase
> (kselftest)
> will be used for stable kernels, it should check the kernel carefully
> and exit with "unsupported" instead of failure.
> 

Yeah, makes sense, will add that check.

Thanks,

Tom