Re: [PATCH 1/2] mmc: tmio: move MFD variant reset to a platform hook

[Wolfram Sang]

Hi Yamada-san,

On Mon, Oct 01, 2018 at 09:31:01PM +0900, Masahiro Yamada wrote:
> CTL_RESET_SDIO register is specific to the TMIO MFD (tmio_mmc.c).
> 
> Add a new hook host->reset for performing a platform-specific reset
> sequence, and move CTL_RESET_SDIO over there.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>

I like it in general.

> +static void tmio_mmc_reset(struct tmio_mmc_host *host)
> +{
> +	sd_ctrl_write16(host, CTL_RESET_SDIO, 0x0000);
> +	usleep_range(10000, 11000);
> +	sd_ctrl_write16(host, CTL_RESET_SDIO, 0x0001);
> +	usleep_range(10000, 11000);
> +}
> +

Are you sure resetting SDIO works independently of resetting SD? Maybe
we should add resetting SD here, too, to keep the pattern...

> --- a/drivers/mmc/host/tmio_mmc_core.c
> +++ b/drivers/mmc/host/tmio_mmc_core.c
> @@ -164,14 +164,13 @@ static void tmio_mmc_reset(struct tmio_mmc_host *host)
>  {
>  	/* FIXME - should we set stop clock reg here */
>  	sd_ctrl_write16(host, CTL_RESET_SD, 0x0000);
> -	if (host->pdata->flags & TMIO_MMC_HAVE_HIGH_REG)
> -		sd_ctrl_write16(host, CTL_RESET_SDIO, 0x0000);
>  	usleep_range(10000, 11000);
>  	sd_ctrl_write16(host, CTL_RESET_SD, 0x0001);
> -	if (host->pdata->flags & TMIO_MMC_HAVE_HIGH_REG)
> -		sd_ctrl_write16(host, CTL_RESET_SDIO, 0x0001);
>  	usleep_range(10000, 11000);

... and have this simplified reset pattern either also in a seperate
function, or doing...

>  
> +	if (host->reset)
> +		host->reset(host);
	else
		simplified_reset_pattern

?

What's your opinion?

Regards,

   Wolfram

Attachment: signature.asc
Description: PGP signature