Re: [PATCH] ARM: dts: imx6sx-sdb: Fix enet phy regulator

From: Fabio Estevam
Date: Tue Oct 02 2018 - 22:25:07 EST


Hi Leonard,

On Tue, Oct 2, 2018 at 3:42 PM Leonard Crestez <leonard.crestez@xxxxxxx> wrote:

> @@ -371,10 +372,12 @@
> MX6SX_PAD_RGMII1_RD1__ENET1_RX_DATA_1 0x3081
> MX6SX_PAD_RGMII1_RD2__ENET1_RX_DATA_2 0x3081
> MX6SX_PAD_RGMII1_RD3__ENET1_RX_DATA_3 0x3081
> MX6SX_PAD_RGMII1_RX_CTL__ENET1_RX_EN 0x3081
> MX6SX_PAD_ENET2_RX_CLK__ENET2_REF_CLK_25M 0x91
> + /* phy reset */
> + MX6SX_PAD_ENET2_CRS__GPIO2_IO_7 0x80000000

We should avoid using 0x80000000 as this relies on the bootloader
setting the IOMUX.

Please do like this insted:

MX6SX_PAD_ENET2_CRS__GPIO2_IO_7 0x10b0

Then you can add:

Reviewed-by: Fabio Estevam <festevam@xxxxxxxxx>