Re: [PATCH v8 RESEND 0/4] Support kdump for AMD secure memory encryption(SME)

From: lijiang
Date: Tue Oct 02 2018 - 23:58:19 EST


å 2018å10æ02æ 19:40, Borislav Petkov åé:
> On Sun, Sep 30, 2018 at 11:10:29AM +0800, Lianbo Jiang wrote:
>> When SME is enabled on AMD machine, it also needs to support kdump. Because
>
> Ok, I've cleaned them up heavily and pushed them here:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git, branch rc6+0-sme-kdump
>
> However, testing on my zen box doesn't go as planned. And this is even before
> your patches.
>
> I load the kdump kernel with kexec-tools from the git-repo + the patch you
> mention:
>
> # ~/bpetkov/bin/sbin/kexec -p /boot/vmlinuz-4.19.0-rc6+ --initrd /boot/initrd-4.19.0-rc6+ --command-line="root=/dev/mapper/ubuntu--010236012132--vg-leap15 splash=silent showopts console=ttyS5,115200 console=tty0 debug ignore_loglevel log_buf_len=16M 1 irqpoll maxcpus=1 reset_devices vga=normal"
>
> verify that it has been loaded:
>
> # grep . /sys/kernel/kexec_*
> /sys/kernel/kexec_crash_loaded:1
> /sys/kernel/kexec_crash_size:268435456
> /sys/kernel/kexec_loaded:0
>
> and then trigger the panic:
>
> # echo c > /proc/sysrq-trigger
>
> and I see the panic happening in the serial console but then nothing.
> The box resets instead.
>
> So something's still broken.
>

Sorry for my late reply because of a holiday.

I noticed that your test was based on [patch v8 RESEND 4/4], could you please
test it based on [patch v9 4/4]? Because the [patch v8 RESEND 4/4] had a compile
error, and that had been fixed in [patch v9 4/4].

Or i improve patch log and comment in the code for [patch v9 4/4] based on your
comments, and post the series again, also provide my test result about the series.
Do you think about?

Thanks.
Lianbo

> Trying the kexec -l/kexec -e game works - the second kernel gets kexeced
> properly.
>