Re: [PATCH] nvmem: only build nvmem_find_cell_by_index() if OF is enabled

From: Bartosz Golaszewski
Date: Wed Oct 03 2018 - 03:19:51 EST


År., 3 paÅ 2018 o 00:26 Greg KH <greg@xxxxxxxxx> napisaÅ(a):
>
> On Tue, Oct 02, 2018 at 01:02:46PM +0200, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
> >
> > The following warning is produced when building nvmem core if
> > CONFIG_OF is disabled:
> >
> > drivers/nvmem/core.c:496:1: warning: 'nvmem_find_cell_by_index' defined but not used [-Wunused-function]
> > nvmem_find_cell_by_index(struct nvmem_device *nvmem, int index)
> > ^~~~~~~~~~~~~~~~~~~~~~~~
> >
> > This is caused by the fact that the only caller of this routine is
> > under an ifdef depending on this option. Fix it by adding a relevant
> > ifdef to the function in question as well.
> >
> > Signed-off-by: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
>
> No "reported-by:" lines on this and the other patch?
>
> Not nice :(

Sorry, I normally remeber about it. Anyway Arnd sent a better
alternative for this one.

Bart