Re: [PATCH v2 2/3] x86/mm/doc: Clean up the memory region layout descriptions

[Baoquan He]

On 10/02/18 at 11:14am, Ingo Molnar wrote:
> 
> * Baoquan He <bhe@xxxxxxxxxx> wrote:
> > -ffffffff80000000 - ffffffff9fffffff (=512 MB)  kernel text mapping, from phys 0
> > -ffffffffa0000000 - fffffffffeffffff (1520 MB) module mapping space
> > +fffffe0000000000 - fffffe7fffffffff (=39 bits, 512 GB) cpu_entry_area mapping
> > +fffffe8000000000 - fffffeffffffffff (=39 bits, 512 GB) LDT remap for PTI
> > +ffffff0000000000 - ffffff7fffffffff (=39 bits, 512 GB) %esp fixup stacks
> > +ffffff8000000000 - fffffffeefffffff (~39 bits, ~507 GB) unused hole
> > +ffffffef00000000 - fffffffeffffffff (=36 bits, 64 GB) EFI region mapping space
> > +ffffffff00000000 - ffffffff7fffffff (=31 bits, 2 GB) unused hole
> > +ffffffff80000000 - ffffffff9fffffff (=29 bits, 512 MB)  kernel text mapping, from phys 0
> > +ffffffffa0000000 - fffffffffeffffff (~31 bits, 1520 MB) module mapping space
> >  [fixmap start]   - ffffffffff5fffff kernel-internal fixmap range
> >  ffffffffff600000 - ffffffffff600fff (=4 kB) legacy vsyscall ABI
> >  ffffffffffe00000 - ffffffffffffffff (=2 MB) unused hole
> 
> Looks mostly good now, but could you please make the right side align vertically as well, like 
> I did in the examples I provided previously?
> 
> There's zero reason for it to look this disorganized:
> 
> > +ffffff8000000000 - fffffffeefffffff (~39 bits, ~507 GB) unused hole
> > +ffffffef00000000 - fffffffeffffffff (=36 bits, 64 GB) EFI region mapping space
> > +ffffffff00000000 - ffffffff7fffffff (=31 bits, 2 GB) unused hole
> > +ffffffff80000000 - ffffffff9fffffff (=29 bits, 512 MB)  kernel text mapping, from phys 0
> 
> I.e. can we do something like:
> 
> > +ffffff8000000000 - fffffffeefffffff (~39 bits, ~507 GB) unused hole
> > +ffffffef00000000 - fffffffeffffffff (=36 bits,   64 GB) EFI region mapping space
> > +ffffffff00000000 - ffffffff7fffffff (=31 bits,    2 GB) unused hole
> > +ffffffff80000000 - ffffffff9fffffff (=29 bits,  512 MB) kernel text mapping, from phys 0

Sure, will change according to your suggestion. Thanks a lot!

> 
> ?
> 
> That not only makes it more readable, but makes typos like the whitespace noise double space in 
> the last line more obvious.
> 
> Thanks,
> 
> 	Ingo