Re: [PATCH] tools/pci: Fix compilation warnings

From: Kishon Vijay Abraham I
Date: Wed Oct 03 2018 - 04:56:41 EST




On Thursday 23 August 2018 05:04 PM, Gustavo Pimentel wrote:
> Fix compilation warnings:
> - remove unused variables
> - change function return from int to void, since it's not used
>
> Signed-off-by: Gustavo Pimentel <gustavo.pimentel@xxxxxxxxxxxx>

Reviewed-by: Kishon Vijay Abraham I <kishon@xxxxxx>
> ---
> tools/pci/pcitest.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/tools/pci/pcitest.c b/tools/pci/pcitest.c
> index 9074b47..8ca1c62 100644
> --- a/tools/pci/pcitest.c
> +++ b/tools/pci/pcitest.c
> @@ -23,7 +23,6 @@
> #include <stdio.h>
> #include <stdlib.h>
> #include <sys/ioctl.h>
> -#include <time.h>
> #include <unistd.h>
>
> #include <linux/pcitest.h>
> @@ -43,17 +42,15 @@ struct pci_test {
> unsigned long size;
> };
>
> -static int run_test(struct pci_test *test)
> +static void run_test(struct pci_test *test)
> {
> long ret;
> int fd;
> - struct timespec start, end;
> - double time;
>
> fd = open(test->device, O_RDWR);
> if (fd < 0) {
> perror("can't open PCI Endpoint Test device");
> - return fd;
> + return;
> }
>
> if (test->barnum >= 0 && test->barnum <= 5) {
>