Re: [PATCH 1/4] mm/hugetlb: Enable PUD level huge page migration

From: Michal Hocko
Date: Wed Oct 03 2018 - 07:28:03 EST


On Wed 03-10-18 12:17:52, Suzuki K Poulose wrote:
[...]
> I have been under the idea that all the checks at the same level could
> have the same indentation. (i.e, 2 tabs in this case for each). Looks
> like there is no rule about it. How about replacing it with a
> switch..case ?

I would simply follow the existing indentation style in that function.
Is this really worth discussig, anyway? Does the proposed change makes
the code harder to read?

--
Michal Hocko
SUSE Labs