Re: [PATCH v4 2/2] [media] imx214: Add imx214 camera sensor driver

[Sakari Ailus]

Hi Ricardo,

On Wed, Oct 03, 2018 at 09:29:05AM +0200, Ricardo Ribalda Delgado wrote:
> Add a V4L2 sub-device driver for the Sony IMX214 image sensor.
> This is a camera sensor using the I2C bus for control and the
> CSI-2 bus for data.
> 
> Tested on a DB820c alike board with Intrinsyc Open-Q 13MP camera.
> 
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@xxxxxxxxx>

How about adding that exposure control? And perhaps analogue and digital
gain as well.

I'd like to see the exposure control there because

	1. it's needed for the driver to be actually usable and

	2. it requires other non-trivial changes to the driver (runtime PM
	   or other arrangements to avoid accessing registers when the
	   power is off).

-- 
Regards,

Sakari Ailus
sakari.ailus@xxxxxxxxxxxxxxx