Re: [PATCH] regulator: fixed: Default enable high on DT regulators

From: Mark Brown
Date: Wed Oct 03 2018 - 08:10:18 EST


On Tue, Oct 02, 2018 at 01:42:38PM +0000, Leonard Crestez wrote:

> This turns the phy off and on again instead of leaving it up from uboot
> and it doesn't work for some reason. However looking at
> reg_fixed_voltage_probe introducing an edge seems to be intentional for
> regulators which are not marked with "enabled-at-boot". Right?

No, that's definitely not desired. We don't want to change the state of
the regulator at all if we can avoid it unless the user explicitly asked
for it.

> It's possible that you exposed an imx board-specific bug: maybe power
> cycling the phy after uboot needs some missing fixup?

It'd probably also be good to sort this out though.

Attachment: signature.asc
Description: PGP signature