Re: [RFC PATCH v2 2/9] dt-bindings: ti-lmu: Remove LM3697
From: Pavel Machek
Date: Wed Oct 03 2018 - 09:01:59 EST
On Wed 2018-10-03 07:24:23, Dan Murphy wrote:
> Hello
>
> On 10/02/2018 02:28 AM, Pavel Machek wrote:
> > On Fri 2018-09-28 13:29:47, Dan Murphy wrote:
> >> Remove support for the LM3697 LED device
> >> from the ti-lmu. The LM3697 will be supported
> >> via a stand alone LED driver.
> >>
> >> Signed-off-by: Dan Murphy <dmurphy@xxxxxx>
> >
> > NAK, for reasons I explained before. Please add it to the patch so
> > that it does not get applied by mistake. Ouch and AFAICT Rob was not
> > happy with this either.
> >
> > Yes, you are creating new drivers, ok; but that does _not_ mean you
> > should create new binding.
>
> I am copying my comment here on the review of this original binding for
> records
>
> I found the review or at least the reference for the ti-lmu.txt binding.
>
> https://lore.kernel.org/patchwork/patch/764180/
>
> Does not appear that the binding was sent to the device tree mail list.
> (Maybe that email list did not exist in Feb 2017).
Quick google shows:
https://lwn.net/Articles/666023/
Now can we stop this nonsense? If there is a problem with the binding,
submit patches to fix the problem.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachment:
signature.asc
Description: Digital signature