Re: [PATCH] spi: slave: Fix missing break in switch

From: Mark Brown
Date: Wed Oct 03 2018 - 11:01:22 EST


On Wed, Oct 03, 2018 at 04:46:45PM +0200, Geert Uytterhoeven wrote:
> On Wed, Oct 3, 2018 at 2:57 PM Gustavo A. R. Silva

> > case CMD_REBOOT:
> > dev_info(&priv->spi->dev, "Rebooting system...\n");
> > kernel_restart(NULL);
> > + break;

> Alternatively, kernel_restart() and friends could be marked __noreturn.

Yes, that seems more sensible though there's no harm in this patch even
with that. It'd definitely avoid other issues in future.

Attachment: signature.asc
Description: PGP signature