Re: [PATCH 2/4] mm: introduce put_user_page(), placeholder version

From: Jan Kara
Date: Wed Oct 03 2018 - 12:22:42 EST


On Thu 27-09-18 22:39:48, john.hubbard@xxxxxxxxx wrote:
> From: John Hubbard <jhubbard@xxxxxxxxxx>
>
> Introduces put_user_page(), which simply calls put_page().
> This provides a way to update all get_user_pages*() callers,
> so that they call put_user_page(), instead of put_page().
>
> Also adds release_user_pages(), a drop-in replacement for
> release_pages(). This is intended to be easily grep-able,
> for later performance improvements, since release_user_pages
> is not batched like release_pages() is, and is significantly
> slower.

A small nit but can we maybe call this put_user_pages() for symmetry with
put_user_page()? I don't really care too much but it would look natural to
me.

Honza

--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR