Re: [PATCH] spi: slave: Fix missing break in switch

[Gustavo A. R. Silva]

On 10/3/18 5:10 PM, Geert Uytterhoeven wrote:
> Hi Gustavo,
> 
> On Wed, Oct 3, 2018 at 5:05 PM Gustavo A. R. Silva
> <gustavo@xxxxxxxxxxxxxx> wrote:
>> On 10/3/18 5:01 PM, Mark Brown wrote:
>>> On Wed, Oct 03, 2018 at 04:46:45PM +0200, Geert Uytterhoeven wrote:
>>>> On Wed, Oct 3, 2018 at 2:57 PM Gustavo A. R. Silva
>>>
>>>>>         case CMD_REBOOT:
>>>>>                 dev_info(&priv->spi->dev, "Rebooting system...\n");
>>>>>                 kernel_restart(NULL);
>>>>> +               break;
>>>
>>>> Alternatively, kernel_restart() and friends could be marked __noreturn.
>>>
>>> Yes, that seems more sensible though there's no harm in this patch even
>>> with that.  It'd definitely avoid other issues in future.
>>
>> I'll include the __noreturn in addition to the break statement.
>> I'll send v2 shortly.
> 
> Please note that adding __noreturn is not a trivial task, due to the complex
> call chains, and the different implementations on the various architectures
> and platforms.  So that will be a big patch series.
> 

I see. In that case, it might be an interesting side project.

I appreciate the feedback, Geert.
--
Gustavo