Re: [RFC PATCH 03/10] arch/x86: Re-arrange RDT init code

[Reinette Chatre]

Hi Babu,

On 10/2/2018 4:41 PM, Moger, Babu wrote:
> On 10/02/2018 02:21 PM, Reinette Chatre wrote:
>> On 9/24/2018 12:19 PM, Moger, Babu wrote:
>>>  static enum cpuhp_state rdt_online;
>>> @@ -866,8 +872,22 @@ static int __init rdt_late_init(void)
>>>  	struct rdt_resource *r;
>>>  	int state, ret;
>>>  
>>> -	if (!get_rdt_resources())
>>> +	/* Run quirks first */
>>> +	rdt_quirks();
>>> +
>>> +	rdt_alloc_capable = get_rdt_alloc_resources();
>>> +	rdt_mon_capable = get_rdt_mon_resources();
>>> +
>>> +	if (!(rdt_alloc_capable || rdt_mon_capable)) {
>>> +		pr_info("RDT allocation or monitoring not detected\n");
>>
>> This function ends with a log entry for every resource discovered. Is
>> this new log entry needed to indicate that such resources have not been
>> found? Could it not just be the absence of the other message?
> 
> As this is relatively new feature, so I added this info message. It helped
> me debug what went wrong. Otherwise, I don't see anything. I can remove it
> if the message is too annoying to the user.

This log entry is made after detection of resources/features supported
by the system. A user would find more information in the
presence/absence of the relevant CPU feature flags in /proc/cpuinfo.

Reinette