Re: [RFC PATCH 00/10] arch/x86: AMD QoS support

From: Moger, Babu
Date: Wed Oct 03 2018 - 16:09:39 EST




On 10/03/2018 01:52 PM, Fenghua Yu wrote:
> On Tue, Oct 02, 2018 at 07:16:23PM +0000, Moger, Babu wrote:
>>
>>
>> On 10/02/2018 01:46 PM, Fenghua Yu wrote:
>>> On Tue, Oct 02, 2018 at 05:44:47PM +0000, Moger, Babu wrote:
>>>> Hi Fenghua,
>>>>
>>>>> -----Original Message-----
>>>>> From: Fenghua Yu <fenghua.yu@xxxxxxxxx>
>>>>> Sent: Tuesday, October 2, 2018 12:07 PM
>>>>> On Mon, Sep 24, 2018 at 07:18:54PM +0000, Moger, Babu wrote:
>>>>>> The public specification is still in works. Will add the link when it is
>>>>>> available.
>>>>>
>>>>> Is this the public AMD QoS spec?
>>>>> https://support.amd.com/TechDocs/56375_Quality_of_Service_Extensions.
>>>>> pdf
>>>>>
>>>>
>>>> Yes. That is the one.
>>>> I was going to send the link after refreshing the patches on 4-19-rc5. You already got it. Please let know if you have any feedback on the patches.
>>>
>>> I don't see the name 'RDT' (Resource Director Technology) in the
>>> spec "AMD64 Technology Platform Quality of Service Extensions".
>>> Does AMD use the same name 'RDT' as Intel?
>>
>> No. AMD uses the word "Platform Quality of Service"(or in short QoS) to
>> refer this feature.
>
> Hi, Thomas, Babu, and James,
>
> Can we use "resctrl" to replace "intel_rdt" and "rdt" in kernel? "resctrl"
> is a neutral name and has been used in user interface already. Hopefully
> "resctrl" can be acceptable by ARM, AMD, and Intel. We only use "intel_rdt",
> "amd_qos", or "arm mpam" for vendor specific code.

Yes. resctrl seems like a reasonable name. >
> Can we move all of Intel RDT, AMD QoS, and ARM MPAM code into a generic
> place fs/resctrl where both ARM and X86 code can stay?

Looking at the James patches, I thought he is going in the same(or
similar) direction eventually.


>
> Thanks.
>
> -Fenghua
>