Re: [PATCH] arm64: dts: qcom: sdm845: Add UART nodes

[Doug Anderson]

Hi,

On Wed, Oct 3, 2018 at 2:12 PM Matthias Kaehlcke <mka@xxxxxxxxxxxx> wrote:
> +                       uart8: serial@a80000 {
> +                               compatible = "qcom,geni-uart";
> +                               reg = <0xa80000 0x4000>;
> +                               clock-names = "se";
> +                               clocks = <&gcc GCC_QUPV3_WRAP0_S0_CLK>;

uart8/10/11/12/13/14/15 are on GCC_QUPV3_WRAP1_S0_CLK, not WRAP0.

Everything else here looks good.  I ran my old hacky script at
<http://crosreview.com/1091631> (mentioned in the message of commit
897cf34e7305 ("arm64: dts: qcom: sdm845: Add I2C, SPI, and UART9
nodes")) after changing it to generate "qcom,geni-uart" as the
compatible string and changing it to generate nodes for all UARTs and
the diff looks fine.

...so once you fix the clock reference feel free to add my Reviewed-by.

-Doug