RE: [PATCHv1] RDMA/core: Check error status of rdma_find_ndev_for_src_ip_rcu

[Parav Pandit]

> -----Original Message-----
> From: linux-rdma-owner@xxxxxxxxxxxxxxx <linux-rdma-
> owner@xxxxxxxxxxxxxxx> On Behalf Of Jason Gunthorpe
> Sent: Wednesday, October 3, 2018 9:48 PM
> To: Parav Pandit <parav@xxxxxxxxxxxx>
> Cc: linux-rdma@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> leon@xxxxxxxxxx; Daniel Jurgens <danielj@xxxxxxxxxxxx>;
> dledford@xxxxxxxxxx
> Subject: Re: [PATCHv1] RDMA/core: Check error status of
> rdma_find_ndev_for_src_ip_rcu
> 
> On Thu, Oct 04, 2018 at 02:28:54AM +0000, Parav Pandit wrote:
> > Hi Doug, Jason,
> >
> > > From: Parav Pandit <parav@xxxxxxxxxxxx>
> > > Sent: Friday, September 21, 2018 10:00 AM
> > > To: linux-rdma@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> > > leon@xxxxxxxxxx; jgg@xxxxxxxx; syzkaller-bugs@xxxxxxxxxxxxxxxx;
> > > Daniel Jurgens <danielj@xxxxxxxxxxxx>; dledford@xxxxxxxxxx
> > > Cc: Parav Pandit <parav@xxxxxxxxxxxx>
> > > Subject: [PATCHv1] RDMA/core: Check error status of
> > > rdma_find_ndev_for_src_ip_rcu
> > >
> > > rdma_find_ndev_for_src_ip_rcu() returns either valid netdev pointer
> > > or ERR_PTR().
> > > Instead of checking for NULL, check for error.
> > >
> > > Fixes: caf1e3ae9fa6 ("RDMA/core Introduce and use
> > > rdma_find_ndev_for_src_ip_rcu")
> > > Reported-by: syzbot+20c32fa6ff84a2d28c36@xxxxxxxxxxxxxxxxxxxxxxxxx
> > > Signed-off-by: Parav Pandit <parav@xxxxxxxxxxxx>
> > > drivers/infiniband/core/addr.c | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/infiniband/core/addr.c
> > > b/drivers/infiniband/core/addr.c index c2ca9e4..3c07eeb 100644
> > > +++ b/drivers/infiniband/core/addr.c
> > > @@ -513,8 +513,8 @@ static int rdma_set_src_addr_rcu(struct
> > > rdma_dev_addr *dev_addr,
> > >  		 * loopback IP address.
> > >  		 */
> > >  		ndev = rdma_find_ndev_for_src_ip_rcu(dev_net(ndev),
> > > dst_in);
> > > -		if (!ndev)
> > > -			return -ENODEV;
> > > +		if (IS_ERR(ndev))
> > > +			return PTR_ERR(ndev);
> > >  	}
> > >
> > >  	return copy_src_l2_addr(dev_addr, dst_in, dst, ndev);
> >
> > Can you please review this fix?  I got below report from syzbot that
> > it tested the patch and reproducer didn't trigger.
> 
> It is very strange, but this patch does not show up in rdma's patch works.
> 
> This happened to Dennis as well for one patch, I'm afraid as a general rule,
> people will need to check that patchworks has thier patches, and maybe talk
> to LF IT about why things have gone missing.
> 
> I would guess it is some spam filter issue?
Not sure, may be something wrong in my mail client configuration.
Most patches are through Leon so I will continue it that way for now.

> 
> I have applied this patch from my email.
Thanks a lot.